MBF21 Skillsaw Codepointers #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraflab
reviewed
May 7, 2021
Mask & translate flags
|
Updated with a new MBF21 flags arg n' some fixins. |
kraflab
reviewed
May 9, 2021
XaserAcheron
force-pushed
the
mbf21-skillsaw-pointers
branch
from
f59804d to
7bcdcd2
Compare
|
WTF, I don't know how those two other files wound up in this commit. o_O Re-pushed, with a better fix this time 'round. |
|
All good 👍 |
|
Just updated the docs, so hopefully this is all kosher-ish now. (Provided my half-asleep brain didn't make any obvious errors, heh :P ) |
kraflab
approved these changes
May 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Skillsaw's suggested codepointers (plus a few variants):
re: Flags pointers, I decided the best way to handle the MF2 flags is to just not (for MBF21 anyway) :P -- seems like a port-support minefield since half the flags are Heretic things rather than "MBF21-spec" stuff, and the most useful flags are in the standard actor flags range anyway, IMO. Better to do it well later than do it poorly now.
Doc update coming soonish -- just wanted to get the code out there for reviewin'.