Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy to the pre-commit hooks #421

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

jacobtomlinson
Copy link
Member

Now that mypy is passing we can add it to the pre-commit hooks.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.33%. Comparing base (87063fc) to head (ce4648e).
Report is 119 commits behind head on main.

Files with missing lines Patch % Lines
kr8s/_exec.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   94.61%   95.33%   +0.71%     
==========================================
  Files          29       31       +2     
  Lines        3141     3662     +521     
==========================================
+ Hits         2972     3491     +519     
- Misses        169      171       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit 851c4d5 into kr8s-org:main Jun 28, 2024
11 checks passed
@jacobtomlinson jacobtomlinson deleted the mypy-precommit branch June 28, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant