Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations for kr8s._config #419

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Jun 28, 2024

Working towards #381. Resolves typing issues in kr8s._config.

The number of mypy errors is down to 12 with this PR.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.32%. Comparing base (87063fc) to head (b1362a4).
Report is 119 commits behind head on main.

Files with missing lines Patch % Lines
kr8s/_config.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   94.61%   95.32%   +0.70%     
==========================================
  Files          29       31       +2     
  Lines        3141     3656     +515     
==========================================
+ Hits         2972     3485     +513     
- Misses        169      171       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit 1ad1fac into kr8s-org:main Jun 28, 2024
11 checks passed
@jacobtomlinson jacobtomlinson deleted the mypy-config branch June 28, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant