Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another round of mypy fixes #415

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

jacobtomlinson
Copy link
Member

More changes towards #381.

Down to 49 errors after this.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.32%. Comparing base (87063fc) to head (3004635).
Report is 118 commits behind head on main.

Files with missing lines Patch % Lines
kr8s/_portforward.py 82.35% 3 Missing ⚠️
kr8s/_api.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
+ Coverage   94.61%   95.32%   +0.70%     
==========================================
  Files          29       30       +1     
  Lines        3141     3639     +498     
==========================================
+ Hits         2972     3469     +497     
- Misses        169      170       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit 853d3f5 into kr8s-org:main Jun 25, 2024
12 checks passed
@jacobtomlinson jacobtomlinson deleted the more-mypy-3 branch June 25, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant