Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit optional types #411

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Jun 19, 2024

Continuing on the path of #381 this PR runs no_implicit_optional on kr8s to add missing Optional types.

This removes around 70 mypy warnings and leaves us with 252.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (87063fc) to head (5bb2cd7).
Report is 116 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
+ Coverage   94.61%   95.35%   +0.73%     
==========================================
  Files          29       29              
  Lines        3141     3619     +478     
==========================================
+ Hits         2972     3451     +479     
+ Misses        169      168       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit ac34334 into kr8s-org:main Jun 19, 2024
12 checks passed
@jacobtomlinson jacobtomlinson deleted the implicit-optional branch June 19, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant