Fix kubeconfig with no clusters #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtomlinson
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #358
In cases where you are using a service account for authentication there may still be a kubeconfig file containing other configuration items. The example in #358 shows using the kubeconfig to store the default namespace.
In these cases the list of clusters in the kubeconfig is
None. This PR updates the config to handle that situation. Config objects correctly reportNonewhen there are no clusters, but it is still possible to read the namespace from the config.The auth module has then been updated to load the namespace from the config and then fall back to service account authentication.
I also took this opportunity to update
KubeConfigandKubeConfigSetto accept dicts instead of paths for programatically creating a kubeconfig as this was useful when writing the tests. This partially implements #357.