Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved gem private key to secrets to avoid secrets leaking #315

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

kpumuk
Copy link
Owner

@kpumuk kpumuk commented Sep 20, 2024

Turns out, using workflow inputs for a secret key was a bad idea:

Run rubygems/release-gem@v1
  with:
    await-release: true
    setup-trusted-publisher: true
  env:
    BUNDLE_GEMFILE: /home/runner/work/meta-tags/meta-tags/gemfiles/rails_7.1.gemfile
    GEM_PRIVATE_KEY_PASSPHRASE: Testing

@kpumuk kpumuk merged commit 9c3948d into main Sep 20, 2024
50 checks passed
@kpumuk kpumuk deleted the gha-release-passphrase branch September 20, 2024 23:32
@kpumuk
Copy link
Owner Author

kpumuk commented Sep 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant