Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Kptfile pipeline functions to reference config by resource name #3515

Open
ChristopherFry opened this issue Aug 29, 2022 · 4 comments · May be fixed by #4178
Open

Allow Kptfile pipeline functions to reference config by resource name #3515

ChristopherFry opened this issue Aug 29, 2022 · 4 comments · May be fixed by #4178
Assignees
@mansoor17syed
Labels
area/hydrate enhancement New feature or request good first issue Good for newcomers p1 triaged Issue has been triaged by adding an `area/` label

Comments

@ChristopherFry
Copy link
Contributor

Requesting kpt is updated to allow Kptfile pipeline functions to reference configs by resource name. Today, the Kptfile Function spec allows configs to be either inline or referenced by config path.

Advantages of this includes allowing kpt to process a stream of resources and would also eliminate an issue where functions do not support references to multi resource yaml files.
@ChristopherFry ChristopherFry added the enhancement New feature or request label Aug 29, 2022
@mortent mortent added area/hydrate triaged Issue has been triaged by adding an `area/` label labels Nov 15, 2022
@yuwenma yuwenma added good first issue Good for newcomers p1 labels Jan 13, 2023
@mortent mortent added this to kpt Jan 21, 2023
@mortent mortent moved this to Backlog in kpt Jan 25, 2023
@mansoor17syed
Copy link

Hi Team,
Can you Please assign this ticket to me
I wish to contribute here

@mikebz
Copy link
Contributor

mikebz commented Dec 29, 2024

done, thank you!

@mansoor17syed mansoor17syed mentioned this issue Dec 31, 2024
Closed
@mansoor17syed
Copy link

mansoor17syed commented Dec 31, 2024 •
edited
Loading

Hi Team,

I've made the changes and raised a MR. As I'm new to this, I'm not sure how well I've done. I'd appreciate your feedback and guidance on how to proceed.

Thanks!

mansoor17syed added a commit to mansoor17syed/kpt that referenced this issue Dec 31, 2024
@mansoor17syed
fix for kptdev#3515 Allowing Kptfile pipeline functions to be referen…
c06a5ff 
…ced by config by resource name

Signed-off-by: mansoora <[email protected]>
@mansoor17syed mansoor17syed linked a pull request Dec 31, 2024 that will close this issue
Open
@mansoor17syed
Copy link

Hi @mikebz @yuwenma @mortent

Can you Please help me review this and share your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mansoor17syed mansoor17syed

Labels
area/hydrate enhancement New feature or request good first issue Good for newcomers p1 triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Milestone
No milestone
5 participants
@mortent @mikebz @ChristopherFry @yuwenma @mansoor17syed