This repository has been archived by the owner on May 15, 2020. It is now read-only.
FIX: Create PipelineRun return 409 if already exists, with detail codes to distinguish different 409s (#TIPD-2118) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 99.86% 99.86% +<.01%
==========================================
Files 41 41
Lines 734 746 +12
==========================================
+ Hits 733 745 +12
Misses 1 1
Continue to review full report at Codecov.
|
JeroennC
force-pushed
the
master
branch
2 times, most recently
from
57cdb95
to
f01d657
Compare
JeroennC
changed the title
mjholtkamp
reviewed
Dec 6, 2019
| @@ -103,7 +103,7 @@ def _add_output(pipeline_output: dict, step_output: str) -> None: | |||
| try: | |||
| pipeline_output.update(json.loads(step_output)) | |||
| except json.JSONDecodeError: | |||
| logging.warning("Invalid JSON in step output") | |||
| log.warning("Invalid JSON in step output") | |||
katka/serializers.py
Outdated
| @@ -27,6 +29,8 @@ | |||
| from rest_framework import serializers | |||
| from rest_framework.exceptions import PermissionDenied | |||
|
|
|||
| log = logging.getLogger("katka") | |||
|
|
|||
There was a problem hiding this comment.
not being used anymore? or is this a fix?
There was a problem hiding this comment.
thanks :) this can be removed idd
…ent 409s with details in the response (#TIPD-2118)
mjholtkamp
approved these changes
Dec 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.