This repository has been archived by the owner on May 15, 2020. It is now read-only.
Feature/commit order #52
Merged
+239
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjholtkamp
commented
Nov 13, 2019
Comment on lines
-38
to
-42
| if kwargs['created'] is True: | ||
| create_release_if_necessary(pipeline) | ||
| else: | ||
| close_release_if_pipeline_finished(pipeline) | ||
|
|
There was a problem hiding this comment.
moved this down to its own post_save signal
mjholtkamp
force-pushed
the
feature/commit-order
branch
from
0677676
to
94ea08f
Compare
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 99.84% 99.85% +<.01%
==========================================
Files 38 39 +1
Lines 658 702 +44
==========================================
+ Hits 657 701 +44
Misses 1 1
Continue to review full report at Codecov.
|
JeroennC
previously approved these changes
Nov 13, 2019
katka/views.py
Outdated
| @@ -95,6 +101,57 @@ class SCMPipelineRunViewSet(FilterViewMixin, AuditViewSet): | |||
| 'release': 'scmrelease', | |||
| } | |||
|
|
|||
| def perform_update(self, serializer): | |||
| status = serializer.initial_data.get('status', None) | |||
There was a problem hiding this comment.
Shouldn't this be verified data?
There was a problem hiding this comment.
Good catch! First I had initial_data, but I changed it (not here) to validated_data). I'll update it!
mjholtkamp
force-pushed
the
feature/commit-order
branch
from
94ea08f
to
f3b79e0
Compare
JeroennC
approved these changes
Nov 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.