-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
if kwargs['created'] is True: | ||
create_release_if_necessary(pipeline) | ||
else: | ||
close_release_if_pipeline_finished(pipeline) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved this down to its own post_save signal
0677676
to
94ea08f
Compare
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 99.84% 99.85% +<.01%
==========================================
Files 38 39 +1
Lines 658 702 +44
==========================================
+ Hits 657 701 +44
Misses 1 1
Continue to review full report at Codecov.
|
katka/views.py
Outdated
@@ -95,6 +101,57 @@ class SCMPipelineRunViewSet(FilterViewMixin, AuditViewSet): | |||
'release': 'scmrelease', | |||
} | |||
|
|||
def perform_update(self, serializer): | |||
status = serializer.initial_data.get('status', None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be verified data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! First I had initial_data, but I changed it (not here) to validated_data). I'll update it!
94ea08f
to
f3b79e0
Compare
No description provided.