Merge pull request #80 from kpn/feature/update-step-bugfix

FIX: UUID is not JSON serializable, force to string
kpn · Feb 11, 2020 · 8b7b752 · 8b7b752
2 parents dbe1901 + c579ead
commit 8b7b752
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/katka/views.py b/katka/views.py
@@ -249,7 +249,7 @@ def call_endpoint(self, serializer):
         data = {
             "user": self.request.user.username,
             "step": {
-                "public_identifier": serializer.instance.public_identifier,
+                "public_identifier": str(serializer.instance.public_identifier),
                 "status": serializer.validated_data["status"],
             },
         }

diff --git a/tests/integration/test_scmsteprun_update_view.py b/tests/integration/test_scmsteprun_update_view.py
@@ -21,7 +21,7 @@ def test_partial_update_status_valid(self, client, logged_in_user, scm_step_run)
         assert len(session.method_calls) == 1
         post = session.method_calls[0][2]["json"]
         assert post["user"] == "test_user"
-        assert post["step"]["public_identifier"] == scm_step_run.public_identifier
+        assert post["step"]["public_identifier"] == str(scm_step_run.public_identifier)
         assert post["step"]["status"] == "success"
 
     def test_partial_update_no_param(self, client, logged_in_user, scm_step_run):