-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement asynchronous responses #11
Conversation
@ebkalderon very nice work! I've changed one of the projects using chrootable-https to your branch and everything worked out of the box after adding I've pushed a branch called |
Looks good to me! I've pulled your change to my branch to get it tested by Travis, just so it's ready to merge. One thing that's missing in this PR but I think might eventually make for a nice addition is the ability to specify a custom executor for the connector, instead of relying on the 4 default threads created by the |
@ebkalderon thanks for all your work! |
@kpcyrd No problem! Thanks for the very useful library. |
Added
ResponseFuture
andPreResolving
types.wait_for_response()
methods to certain futures, which drives them to completion using atokio::Runtime
and returns aResult
, restoring the original synchronous behavior.Changed
Client
,Connector
, andResolver
fully asynchronous.get.rs
example to usewait_for_response()
.Send + Sync
bounds onDnsResolver
trait.DnsResolver
to return aResolving
future.#[must_use]
attribute to all futures.cargo fmt
on the codebase.Removed
AsyncResolver
andAsyncResolverFuture
types.trust-dns-proto
crate.Closes #10.