Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nested nullable enums #425

Merged
merged 1 commit into from
May 5, 2021

Conversation

philipbjorge
Copy link
Contributor

@philipbjorge philipbjorge commented May 5, 2021

This is a fix for #424

Checked

  • ./scripts/test.sh
  • ./scripts/format.sh
  • ./scripts/lint.sh (I am getting some errors here but no files related to this change)
datamodel_code_generator/format.py:54: error: Module has no attribute "__version__"
datamodel_code_generator/format.py:57: error: Module has no attribute "Config"
datamodel_code_generator/format.py:67: error: Module has no attribute "__version__"
datamodel_code_generator/format.py:70: error: Module has no attribute "SortImports"
datamodel_code_generator/format.py:77: error: Module has no attribute "code"

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #425 (bc4c669) into master (e9b6edf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #425     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           11        20      +9     
  Lines         1020      2131   +1111     
  Branches       201       417    +216     
===========================================
+ Hits          1020      2131   +1111     
Flag Coverage Δ
unittests 99.90% <99.87%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamodel_code_generator/model/__init__.py 100.00% <ø> (ø)
datamodel_code_generator/__init__.py 100.00% <100.00%> (ø)
datamodel_code_generator/__main__.py 100.00% <100.00%> (ø)
datamodel_code_generator/format.py 100.00% <100.00%> (ø)
datamodel_code_generator/http.py 100.00% <100.00%> (ø)
datamodel_code_generator/imports.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/base.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/enum.py 100.00% <100.00%> (ø)
...atamodel_code_generator/model/pydantic/__init__.py 100.00% <100.00%> (ø)
...amodel_code_generator/model/pydantic/base_model.py 100.00% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe505d9...bc4c669. Read the comment docs.

@koxudaxi koxudaxi merged commit af9f495 into koxudaxi:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants