Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AppVeyor CI config #347

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Refactor AppVeyor CI config #347

merged 1 commit into from
Oct 9, 2019

Conversation

chshersh
Copy link
Contributor

@chshersh chshersh commented Oct 9, 2019

AppVeyor CI fails for some weird reason. This is happening because we're using the latest cabal and cabal-3.0 doesn't work (yet). Instead of figuring out, why it doesn't work, I just fixed cabal version to 2.4 and I also used this appveyor.yml script from this blog post:

@chshersh chshersh added CI CI tools support; project CI; build with different GHC, tools windows Windows system support labels Oct 9, 2019
@chshersh chshersh requested a review from vrom911 October 9, 2019 09:36
@chshersh chshersh self-assigned this Oct 9, 2019
vrom911
vrom911 reviewed Oct 9, 2019
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Should we also patch the generated one?

@chshersh
Copy link
Contributor Author

chshersh commented Oct 9, 2019

@vrom911 I think no... We have a separate issue for patching generated appveyor.yml file: #327

We can use this one for cabal and for default and copy from relude for stack-only projects.
Also, let's see how good it is and how well it builds for some time 🙂

@vrom911 vrom911 merged commit 4e900de into master Oct 9, 2019
@vrom911 vrom911 deleted the chshersh/fix-appveyor-ci branch October 9, 2019 11:53
@chshersh chshersh added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrom911 vrom911 vrom911 approved these changes

Assignees

@chshersh chshersh

Labels
CI CI tools support; project CI; build with different GHC, tools Hacktoberfest https://hacktoberfest.digitalocean.com/ windows Windows system support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chshersh @vrom911