Skip to content
This repository has been archived by the owner on Nov 7, 2020. It is now read-only.

[#29] Improve documentation #44

Merged
merged 2 commits into from
Sep 24, 2018
Merged

[#29] Improve documentation #44

merged 2 commits into from
Sep 24, 2018

Conversation

chshersh
Copy link
Contributor

Resolves #29
Resolves #43

@chshersh chshersh added the doc label Sep 24, 2018
@chshersh chshersh self-assigned this Sep 24, 2018
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes!

README.md Outdated
> bad act the good. Each should have its own reward. You were a hero and a
> smuggler.”
>
> ― George R.R. Martin, A Clash of Kings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can have only the first one (I love it more 🙂 )

README.md Outdated

```
-fplugin=Smuggler.Plugin
```

## Build instructions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder should we call such sections "For developer" or smth like this?

app/Main.hs Outdated
import Data.List (sort)
import Data.Maybe (fromMaybe, maybe)
import Data.Bool (Bool ( True), bool)
import Data.Maybe (fromMaybe,)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

@chshersh chshersh merged commit 17ad48f into master Sep 24, 2018
@chshersh chshersh deleted the chshersh/29-readme branch September 24, 2018 05:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants