Replace the deprecated imghdr module

[page-down]

When running . /tests.py mypy, it shows the following message and fails (exit code 1).

DeprecationWarning: 'imghdr' is deprecated and slated for removal in Python 3.13

I noticed that the relevant remote control commands cannot be executed via shortcuts.

kitty -o 'map f1 remote_control set-window-logo /path/to/png'

kitty.rc.base.StreamError: No stream_id in rc payload

Since this is related to the remote control protocol, could you update the documentation if you have some time? (And maybe the async part, such as async_id)
https://sw.kovidgoyal.net/kitty/rc_protocol/

The detailed traceback is printed before the Press e to see detailed traceback ... line. This minor issue is not important.

I see the use of NamedTemporaryFile in setting the background image and logo, is it possible to use SHM to avoid higher file system IO (writes) when setting dynamically generated images in high frequency?

Is it intentional not to reload the background image after reloading the configuration?

[kovidgoyal]

On Tue, Feb 28, 2023 at 08:33:06PM -0800, page-down wrote: When running `. /tests.py mypy`, it shows the following message and fails (exit code 1). ```log DeprecationWarning: 'imghdr' is deprecated and slated for removal in Python 3.13 ``` I noticed that the relevant remote control commands cannot be executed via shortcuts. ```shell kitty -o 'map f1 remote_control set-window-logo /path/to/png' ```

This is on my TODO list I never got around to porting it after changing RC to Go.

```log kitty.rc.base.StreamError: No stream_id in rc payload ``` Since this is related to the remote control protocol, could you update the documentation if you have some time? (And maybe the async part, such as `async_id`) https://sw.kovidgoyal.net/kitty/rc_protocol/ The detailed traceback is printed before the `Press e to see detailed traceback ...` line. This minor issue is not important. I see the use of `NamedTemporaryFile` in setting the background image and logo, is it possible to use SHM to avoid higher file system IO (writes) when setting dynamically generated images in high frequency?

It doesn't actually need a file at all, its just there for code re-use.

Is it intentional not to reload the background image after reloading the configuration?

I dont think so would have to look at the code to be sure.

[kovidgoyal]

On Tue, Feb 28, 2023 at 08:33:06PM -0800, page-down wrote: When running `. /tests.py mypy`, it shows the following message and fails (exit code 1). ```log DeprecationWarning: 'imghdr' is deprecated and slated for removal in Python 3.13 ``` I noticed that the relevant remote control commands cannot be executed via shortcuts. ```shell kitty -o 'map f1 remote_control set-window-logo /path/to/png' ``` ```log kitty.rc.base.StreamError: No stream_id in rc payload ``` Since this is related to the remote control protocol, could you update the documentation if you have some time? (And maybe the async part, such as `async_id`) https://sw.kovidgoyal.net/kitty/rc_protocol/ The detailed traceback is printed before the `Press e to see detailed traceback ...` line. This minor issue is not important. I see the use of `NamedTemporaryFile` in setting the background image and logo, is it possible to use SHM to avoid higher file system IO (writes) when setting dynamically generated images in high frequency?

Actually NamedTemporaryFile here is a dummy class, it doesnt touch the filesystem.

[page-down]

... is it possible to use SHM ...

It doesn't actually need a file at all, its just there for code re-use.

In fact, in handle_streamed_data -> StreamInFlight, handle_data is still writing to the temporary file.
The following will not work.
And high frequency updates will result in high file system IO.

cat image.png | kitten @ set-window-logo /dev/stdin

Failed to decode PNG image at: /var/folders/.../.../T/tmpjisxwfhh.png

I noticed the relevant codes.

state.c, set_window_logo
window_logo.c, find_or_create_window_logo
graphics.c, png_path_to_bitmap, `FILE* fp = fopen(path, "r"); ...; log_error("Failed to decode PNG image at: %s", path);`

[kovidgoyal]

On Tue, Feb 28, 2023 at 09:21:34PM -0800, page-down wrote: >> ... is it possible to use SHM ... > > It doesn't actually need a file at all, its just there for code re-use. In fact, in `handle_streamed_data` -> `StreamInFlight`, `handle_data` is still writing to the temporary file.

Yes of course, actually changing the image requires a file, since getting libpng to load data from memory is a huge pain. I meant the code path for clearing the image. We cant really use SHM as there are lots of systems where SHM is not turned on or broken, so one would have to write code to very carefully check and fallback.

[kovidgoyal]

Although rather than SHM one can use fmemopen assuming it works on macOS

[page-down]

Yes of course, ...

Thanks for the explanation, it's not easy to create a memory file system under macOS.
Unfortunately, even if there are GBs of free memory space, the memory is sitting there and cannot be used.

One use case is to dynamically generate a progress bar or other background task information for the current window.
Rather than generating a temporary file, I would rather send the encoded image directly to the UNIX socket server and render it.