Add force_ltr
#2293
Merged
Add force_ltr
#2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I agreed it's a bandaid, but at least it makes sane bidi editing with vim possible.
Sometimes, it pays for a program not to be too smart...
…On 17 January 2020 10:24:43 GMT+02:00, Fredrick Brennan ***@***.***> wrote:
Close #2252.
This allows users to forcibly disable RTL; since Kitty doesn't
support BIDI anyway, this makes selecting RTL substrings more
tolerable, but many users may prefer the current behavior, so it's
off by default.
@kovidgoyal called this a "bandaid", and I understand why,
but I hope he merges it because I find it useful, and I know that @hseg
will too
You can view, comment on, or merge this pull request online at:
#2293
-- Commit Summary --
* Add `force_ltr`
-- File Changes --
M kitty/config_data.py (19)
M kitty/fonts.c (1)
M kitty/state.c (1)
M kitty/state.h (1)
-- Patch Links --
https://github.com/kovidgoyal/kitty/pull/2293.patch
https://github.com/kovidgoyal/kitty/pull/2293.diff
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#2293
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
|
I agree. I come into contact with Hebrew text surprisingly frequently, as I make fonts and some of my build scripts and tests include Hebrew text. So I need to be able to select Hebrew substrings, which is basically impossible with the current way things work. I hope this will get merged even though Kovid closed your issue. It can always be taken out if full BIDI support is added, and it's optional |
|
I said I dont want to spend the time on it, I have no objections to |
|
The push I just made was a documentation-only change. I realized that this commit is much more useful than I originally thought—it allows GNU FriBidi to work with Kitty!
This was completely unintentional, but very useful! |
Add above fact to documentation.
ahmedelgabri
added a commit
to ahmedelgabri/dotfiles
that referenced
this pull request
Jan 28, 2020
Kitty doesn't support RTL & the author mentioned a couple of times that he has no plans to do so, what a bummer. But in 0.16.0 he added this hack/workaround to force rendering always as LTR which weirdly enough improved the RTL support at least became tolerable kovidgoyal/kitty#2293 (comment) More context: kovidgoyal/kitty#2293 kovidgoyal/kitty#2252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2252.
This allows users to forcibly disable RTL; since Kitty doesn't support BIDI anyway, this makes selecting RTL substrings more tolerable, but many users may prefer the current behavior, so it's off by default.
@kovidgoyal called this a "bandaid", and I understand why, but I hope he merges it because I find it useful, and I know that @hseg will too