Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/docker4build #192

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Feature/docker4build #192

merged 3 commits into from
Jun 7, 2022

Conversation

Skeeve
Copy link
Contributor

@Skeeve Skeeve commented May 31, 2022

Just a docker-compose.yaml to help developers to compile without installing go.

image: golang:latest
environment:
# MacOS 64-bit
- GOOS=darwin
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this as default behavior? Can't we just comment all the entries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever you prefer. These are my settings and it's not an issue at all to change them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed it so that the values are taken from the environment.

@kovetskiy kovetskiy merged commit ac2132b into kovetskiy:master Jun 7, 2022
@Skeeve Skeeve deleted the feature/docker4build branch June 7, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants