Add support for encrypted async blob read #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotwanikunal
commented
Sep 12, 2023
...er/src/main/java/org/opensearch/common/blobstore/AsyncMultiStreamEncryptedBlobContainer.java
Outdated
Show resolved
Hide resolved
kotwanikunal
commented
Sep 12, 2023
...er/src/main/java/org/opensearch/common/blobstore/AsyncMultiStreamEncryptedBlobContainer.java
Outdated
Show resolved
Hide resolved
vikasvb90
reviewed
Sep 13, 2023
...er/src/main/java/org/opensearch/common/blobstore/AsyncMultiStreamEncryptedBlobContainer.java
Show resolved
Hide resolved
...er/src/main/java/org/opensearch/common/blobstore/AsyncMultiStreamEncryptedBlobContainer.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/opensearch/common/blobstore/AsyncMultiStreamEncryptedBlobContainer.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/opensearch/common/blobstore/AsyncMultiStreamEncryptedBlobContainer.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/opensearch/common/blobstore/AsyncMultiStreamEncryptedBlobContainer.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/opensearch/common/blobstore/AsyncMultiStreamEncryptedBlobContainer.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/opensearch/common/blobstore/AsyncMultiStreamEncryptedBlobContainer.java
Outdated
Show resolved
Hide resolved
| } catch (IOException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| this.fileSize = this.cryptoHandler.estimateDecryptedLength(cryptoContext, readContext.getBlobSize()); |
There was a problem hiding this comment.
Can we avoid doing it here and delay it till getBlobSize() so that we spend compute only when getBlobSize is invoked? Also once invoked you can cache it and keep returning the cached fileSize to avoid redundant compute.
...er/src/main/java/org/opensearch/common/blobstore/AsyncMultiStreamEncryptedBlobContainer.java
Show resolved
Hide resolved
kotwanikunal
force-pushed
the
encrypted-async-downloads
branch
from
5c5b8c0
to
15395dc
Compare
kotwanikunal
force-pushed
the
encrypted-async-downloads
branch
3 times, most recently
from
2de1ab6
to
421d3c5
Compare
Signed-off-by: Kunal Kotwani <[email protected]>
Signed-off-by: Kunal Kotwani <[email protected]>
kotwanikunal
force-pushed
the
encrypted-async-downloads
branch
from
421d3c5
to
5551aaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.