-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a heelo mesage and a gif of a typing cat #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @kt-lmb, welcome to the course!
please remove empty lines 495-497, they are unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kt-lmb, well done! But could you please place your image under gif/
directory?
You will probably need to rename it and change a reference to it in README.md
@kt-lmb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kt-lmb , not bad.
But it seems like you replaced someone's else code. Let's not make them upset.
Please, bring their code back.
You have also replaced a link to a local image with a link to a remote resource. This will definitely work.
Now the repo doesn't need neither ./giphy.gif
nor ./gif/typingCat.gif
as they aren't referred to anywhere. Please, remove those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Looks good to me)
good job!
@kt-lmb , you are almost done! P.S. It might be challenging but the benefit for you is that you level-up your git skills! Hurry! There are other PRs that may provoke a merge conflict! |
@kt-lmb , you have successfully removed Now there is also a formal merge conflict as Will you resolve it? You need to keep only one of two alternatives (hint: the second one is empty but it is in place. Sounds weird, I know). Built-in github conflict resolver is very helpful. |
@kt-lmb grats! You did it! |
No description provided.