Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ New StrictlyNegativeInt.Companion.create* factory functions #347

Closed
5 tasks done
Tracked by #439 ...
LVMVRQUXL opened this issue Dec 21, 2023 · 2 comments
Closed
5 tasks done
Tracked by #439 ...

✨ New StrictlyNegativeInt.Companion.create* factory functions #347

LVMVRQUXL opened this issue Dec 21, 2023 · 2 comments
Assignees
Labels
common Item related to all platforms. feature New feature or request.
Milestone

Comments

@LVMVRQUXL
Copy link
Contributor

LVMVRQUXL commented Dec 21, 2023

📝 Description

We would like to add create* experimental factory functions to the StrictlyNegativeInt.Companion type for all platforms with the following signature:

fun StrictlyNegativeInt.Companion.create(number: Number): StrictlyNegativeInt
fun StrictlyNegativeInt.Companion.createOrNull(number: Number): StrictlyNegativeInt?

The StrictlyNegativeInt type being incompatible with Java due to its declaration as inline value class, these functions shouldn't be available yet for Java users.

✅ Checklist

  • Add the create function, test its behaviour with Kotlin and update the public API binaries.
  • Add the createOrNull function, test its behaviour with Kotlin and update the public API binaries.
  • Add entry in the unreleased changelog.
  • Improve the documentation of the create and the createOrNull functions by indicating that they may involve rounding or truncation.
  • Close this issue as completed and update tracking ones if present.
@LVMVRQUXL LVMVRQUXL added feature New feature or request. common Item related to all platforms. labels Dec 21, 2023
@LVMVRQUXL LVMVRQUXL added this to the 4.4.0 milestone Dec 21, 2023
@LVMVRQUXL LVMVRQUXL changed the title New static factory function named of for StrictlyNegativeInt New static factory function for StrictlyNegativeInt Dec 22, 2023
@LVMVRQUXL LVMVRQUXL changed the title New static factory function for StrictlyNegativeInt New factory function StrictlyNegativeInt.Companion.from Dec 22, 2023
@LVMVRQUXL LVMVRQUXL modified the milestones: 4.4.0, 4.4.1 Dec 28, 2023
@LVMVRQUXL LVMVRQUXL changed the title New factory function StrictlyNegativeInt.Companion.from New StrictlyNegativeInt.Companion.create* factory functions Jan 7, 2024
@LVMVRQUXL LVMVRQUXL added this to the 4.4.1 milestone Jan 7, 2024
@LVMVRQUXL
Copy link
Contributor Author

We should wait for the issue #371 to be resolved before implementing this one.

@LVMVRQUXL LVMVRQUXL removed this from the 4.4.1 milestone Jan 25, 2024
@LVMVRQUXL LVMVRQUXL added this to the 4.5.0 milestone Feb 3, 2024
@LVMVRQUXL LVMVRQUXL assigned LVMVRQUXL and unassigned LVMVRQUXL Feb 3, 2024
@LVMVRQUXL LVMVRQUXL removed this from the 4.5.0 milestone Feb 3, 2024
@LVMVRQUXL LVMVRQUXL added this to the 4.5.0 milestone Feb 8, 2024
@LVMVRQUXL LVMVRQUXL self-assigned this Feb 21, 2024
@LVMVRQUXL LVMVRQUXL changed the title New StrictlyNegativeInt.Companion.create* factory functions ✨ New StrictlyNegativeInt.Companion.create* factory functions Feb 28, 2024
@LVMVRQUXL
Copy link
Contributor Author

We reopen this issue for improving the documentation of these new functions be indicating that these may involve rounding or truncation.

@LVMVRQUXL LVMVRQUXL reopened this Mar 7, 2024
LVMVRQUXL added a commit that referenced this issue Mar 8, 2024
Indicates that these functions may involve rounding or truncation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Item related to all platforms. feature New feature or request.
Projects
None yet
Development

No branches or pull requests

1 participant