Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matchers for Kotlinx Time #1629

Merged
merged 3 commits into from
Aug 17, 2020
Merged

Add matchers for Kotlinx Time #1629

merged 3 commits into from
Aug 17, 2020

Conversation

LeoColman
Copy link
Member

This commit implements most of the basic matchers with LocalDate + LocalDateTime for the new kotlinx.time types.

As the kotlinx library improves, we should follow and try to improve on our side as well.

As the matchers are very similar to our current datetime matchers, I don't believe we need to add extra documentation at the matchers page, but can do if you find it necessary.

@LeoColman LeoColman added enhancement ✨ Suggestions for adding new features or improving existing ones. assertions 🔍 Related to the assertion mechanisms within the testing framework. labels Aug 14, 2020
@LeoColman LeoColman requested a review from sksamuel August 14, 2020 04:57
@LeoColman LeoColman self-assigned this Aug 14, 2020
@LeoColman
Copy link
Member Author

I couldn't find a way to add these to the ConstantNowListener, as mocking is not very easy on multiplatform kotlin.

I created Kotlin/kotlinx-datetime#33 to try to find a solution, let's see what comes from there :D

@sksamuel
Copy link
Member

Some test failures, otherwise looks good.

@LeoColman LeoColman force-pushed the feature/1628-kotlinx-time branch from 555a35a to a994233 Compare August 17, 2020 03:31
@sksamuel
Copy link
Member

Merging in

@sksamuel sksamuel merged commit 2806499 into master Aug 17, 2020
@sksamuel sksamuel deleted the feature/1628-kotlinx-time branch August 17, 2020 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assertions 🔍 Related to the assertion mechanisms within the testing framework. enhancement ✨ Suggestions for adding new features or improving existing ones.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants