Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for kotest 0.5.0+, upgrade gradle, kotlin #38

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

dhoepelman
Copy link
Collaborator

Due to removing the variance from Invalid (it now extends ValidationResult<Nothing>) in kotest 0.5.0 this library has been broken with newer konform versions.

Interestingly enough it crashes the kotlin compiler itself, so will see if I can scrounge up the error and report it to Jetbrains.

This PR fixes that and upgrades konform to the latest 0.6.2.
This also allows me to start using kotest in the project itself.

@sksamuel I'm the new maintainer of konform. Might be interested in performing some maintenance work on this if I get around to it. Mind giving me write access to the repo so I can open PRs directly against it instead of against a fork?

Things I see:

  • Upgrade to Kotlin 2
  • Adding all kotlin native targets, konform added all multiplatform targets
  • Add/improve matchers
  • Upgrade gradle (might leave this to kotest maintainer(s) as this is a kotest project so it matches that setup)

@dhoepelman dhoepelman changed the title Fix for kotest 0.5.0+ Fix for kotest 0.5.0+, upgrade gradle, kotlin Sep 9, 2024
@dhoepelman
Copy link
Collaborator Author

Had to also upgrade kotlin and gradle to get the build to work.

@sksamuel
Copy link
Member

I've given you write access @dhoepelman

@sksamuel sksamuel merged commit cb1d20b into kotest:master Sep 10, 2024
1 check passed
@dhoepelman
Copy link
Collaborator Author

@sksamuel thanks for access and merging!

@dhoepelman dhoepelman deleted the dhoepelman/upgrade-kotest branch September 10, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants