feat: add code implementation of the basic framework of resource I/O … #83
Conversation
|
/lgtm |
|
we can consider if to use controller-runtime to unify the informer framework |
cmd/koslet/app/koslet.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func buildClient() (kubernetes.Interface, error) { |
There was a problem hiding this comment.
Can we unify the clientset building process or we can put it into a common utils
There was a problem hiding this comment.
Okay, I'll modify it
|
New changes are detected. LGTM label has been removed. |
wangyizhi1
force-pushed
the
main
branch
3 times, most recently
from
f474e34 to
6488475
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yuleichun-striving The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
feature
What does this PR do?
add code implementation of the basic framework of resource I/O isolation
Which issue(s) does this PR fix?
Fixes #20
Special notes for your reviewer:
Review whether the code implementation is reasonable
Related Projects:
kosmos-io