Add notready status upload part for one2cluster in UpdateRootNodeStatus #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duanmengkk
reviewed
Dec 15, 2024
| if err != nil && healthStatus == http.StatusNotFound { | ||
| healthStatus, err := healthEndpointCheck(leafClient, "/healthz") | ||
| if err != nil { | ||
| klog.Errorf("Failed to healthEndpointCheck healthStatus is %v, err is : %v ", healthStatus, err) |
There was a problem hiding this comment.
Suggested change
| klog.Errorf("Failed to healthEndpointCheck healthStatus is %v, err is : %v ", healthStatus, err) | |
| klog.Errorf("Health check failed. Current health status: %v, error: %v", healthStatus, err) | |
| return false, false | ||
| } | ||
| if healthStatus != http.StatusOK { | ||
| klog.Infof("Member cluster %v isn't healthy", h.Cluster.Name) |
There was a problem hiding this comment.
Suggested change
| klog.Infof("Member cluster %v isn't healthy", h.Cluster.Name) | |
| klog.Warnf("Member cluster %v isn't healthy", h.Cluster.Name) |
| Type: corev1.NodeReady, | ||
| Status: corev1.ConditionFalse, | ||
| Reason: "LeafNodesNotReady", | ||
| Message: "All leaf nodes are not ready.", |
There was a problem hiding this comment.
Suggested change
| Message: "All leaf nodes are not ready.", | |
| Message: "All leaf cluster‘s master nodes are not ready.", |
| @@ -150,7 +151,15 @@ func (h ClassificationHandler) UpdateRootNodeStatus(ctx context.Context, nodesIn | |||
| Effect: utils.KosmosNodeTaintEffect, | |||
| }) | |||
| } else { | |||
| rootCopy.Status.Conditions = utils.NodeConditions() | |||
| //rootCopy.Status.Conditions = utils.NodeConditions() | |||
| online, healthy := h.getClusterHealthStatus(h.LeafClientset) | |||
There was a problem hiding this comment.
Suggested change
| online, healthy := h.getClusterHealthStatus(h.LeafClientset) | |
| // TODO A node's status should be set to false only after it has been determined that it is offline for three consecutive timing cycles. | |
| online, healthy := h.getClusterHealthStatus(h.LeafClientset) |
| return []corev1.NodeCondition{ | ||
| { | ||
| Type: corev1.NodeReady, | ||
| Status: corev1.ConditionFalse, |
There was a problem hiding this comment.
Suggested change
| Status: corev1.ConditionFalse, | |
| Status: corev1.ConditionTrue, |
The unhealthy member cluster does not necessarily mean that the nodes are in a not-ready state.
Signed-off-by: luchunling <[email protected]>
lcl533
force-pushed
the
dev_updaterootnodestatus
branch
from
99cbabb to
c4173c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What does this PR do?
Add notready status upload part for one2cluster in UpdateRootNodeStatus
Which issue(s) does this PR fix?
Fixes #When the main cluster cannot connect to the sub-cluster, rootnode is notready
When connecting to the sub-cluster, when all master nodes are notready, rootnode is notready
Special notes for your reviewer:
Does this PR introduce a user-facing change?