sync podstatus from leaf to root when root node from ready to notready #770
+5,501
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gao12312
force-pushed
the
pod_snyc
branch
2 times, most recently
from
7e73738 to
ca3f31b
Compare
gao12312
force-pushed
the
pod_snyc
branch
2 times, most recently
from
f2db91b to
6428c2e
Compare
gao12312
force-pushed
the
pod_snyc
branch
2 times, most recently
from
a7c3205 to
0467e7f
Compare
gao12312
force-pushed
the
pod_snyc
branch
7 times, most recently
from
5c86aee to
1a2ede0
Compare
duanmengkk
reviewed
Dec 11, 2024
pkg/clustertree/cluster-manager/controllers/pod/rootpodstatus_sync_controller.go
Outdated
Show resolved
Hide resolved
gao12312
force-pushed
the
pod_snyc
branch
2 times, most recently
from
a032fb4 to
21c2c70
Compare
|
add unit test |
Signed-off-by: gaoyuan <[email protected]>
rxy0210
reviewed
Dec 19, 2024
| }, | ||
| UpdateFunc: func(updateEvent event.UpdateEvent) bool { | ||
| pod1 := updateEvent.ObjectOld.(*corev1.Pod) | ||
| pod2 := updateEvent.ObjectNew.(*corev1.Pod) |
| if !skipFunc(updateEvent.ObjectNew) { | ||
| return false | ||
| } | ||
| return !reflect.DeepEqual(pod1.Status, pod2.Status) |
There was a problem hiding this comment.
skipFunc and reflect.DeepEqual can be written together
| return reconcile.Result{}, nil | ||
| } | ||
|
|
||
| if !c.GlobalLeafManager.HasNode(rootpod.Spec.NodeName) { |
There was a problem hiding this comment.
In one2cluster mode, the nodename of the rootpod is not in the subset cluster
| if !skipFunc(updateEvent.ObjectNew) { | ||
| return false | ||
| } | ||
| return !reflect.DeepEqual(pod1.Status, pod2.Status) |
There was a problem hiding this comment.
You should only judge the conditions in status, not all the contents of status
| return reconcile.Result{RequeueAfter: utils.DefaultRequeueTime}, nil | ||
| } | ||
|
|
||
| if !podutils.IsKosmosPod(&rootpod) { |
| return reconcile.Result{}, nil | ||
| } | ||
|
|
||
| if podutils.IsKosmosPod(leafPod) && !reflect.DeepEqual(rootpod.Status, leafPod.Status) { |
| podutils.FitObjectMeta(&rPodCopy.ObjectMeta) | ||
| if err := c.RootClient.Status().Update(ctx, rPodCopy); err != nil && !apierrors.IsNotFound(err) { | ||
| klog.Errorf("error while updating rootpod status in kubernetes, %s", err) | ||
| return reconcile.Result{}, nil |
| rPodCopy := rootpod.DeepCopy() | ||
| rPodCopy.Status = leafPod.Status | ||
| podutils.FitObjectMeta(&rPodCopy.ObjectMeta) | ||
| if err := c.RootClient.Status().Update(ctx, rPodCopy); err != nil && !apierrors.IsNotFound(err) { |
There was a problem hiding this comment.
apierrors.IsNotFound is redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What does this PR do?
sync podstatus from leaf to root when root node from ready to notready
Which issue(s) does this PR fix?
Fixes #705
Special notes for your reviewer:
Does this PR introduce a user-facing change?