improve node agent for serve and client #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangdepeng <[email protected]>
village-way
force-pushed
the
feature_nodeagent
branch
from
fd7624a to
0b69bb9
Compare
|
/lgtm |
village-way
force-pushed
the
feature_nodeagent
branch
3 times, most recently
from
88e1cce to
ff8dc62
Compare
duanmengkk
reviewed
Jul 10, 2024
| Long: "execute command on remote server use pyt", | ||
| RunE: cmdTtyRun, | ||
| } | ||
| wg sync.WaitGroup |
There was a problem hiding this comment.
一个命令一个文件，如果有子命令就建一个文件夹，按照这样来吧
There was a problem hiding this comment.
To avoid too many directories, create subdirectories only for second-level subcommands, referring to the design of kubectl.
village-way
force-pushed
the
feature_nodeagent
branch
from
ff8dc62 to
dbd6872
Compare
village-way
force-pushed
the
feature_nodeagent
branch
2 times, most recently
from
84091b8 to
34b812a
Compare
Signed-off-by: wangdepeng <[email protected]>
village-way
force-pushed
the
feature_nodeagent
branch
from
34b812a to
2b3c137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What does this PR do?
Which issue(s) does this PR fix?
Fixes #648
Special notes for your reviewer:
Does this PR introduce a user-facing change?