Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add kube-proxy in virtualcluster #594

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

rxy0210
Copy link
Member

@rxy0210 rxy0210 commented May 28, 2024

What type of PR is this?

/kind bug

What does this PR do?

fix: add kube-proxy in virtualcluster

Which issue(s) does this PR fix?

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


pkg/kubenest/constants/constant.go Show resolved Hide resolved
kubeconfig: /var/lib/kube-proxy/kubeconfig.conf
qps: 100
clusterCIDR: 172.19.0.0/16,fd22:2222:2222::/48
configSyncPeriod: 0s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Associate configuring clusterCIDR with configuring calico-node.CALICO_IPV4POOL_CIDR

@OrangeBao
Copy link
Contributor

/lgtm

@rxy0210
Copy link
Member Author

rxy0210 commented May 29, 2024

i have fixed up

@duanmengkk
Copy link
Contributor

resolve conflicts first

Verified

This commit was signed with the committer’s verified signature.
gao12312 GaoYuan
Signed-off-by: renxiangyu_yewu <renxiangyu_yewu@cmss.chinamobile.com>
@rxy0210
Copy link
Member Author

rxy0210 commented Jun 12, 2024

resolve conflicts first

fixed

@duanmengkk
Copy link
Contributor

/lgtm
/approve

@kosmos-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: duanmengkk, rxy0210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kosmos-robot kosmos-robot merged commit b6925c7 into kosmos-io:main Jun 12, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants