Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add make node-agent target and improve the cmd return formate #495

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

village-way
Copy link
Contributor

What type of PR is this?

/kind bug

What does this PR do?

  1. improve the /cmd return code formate
  2. add make node-agent target
  3. tidy directory structure

Which issue(s) does this PR fix?

Fixes #

Special notes for your reviewer:

@duanmengkk @OrangeBao

Does this PR introduce a user-facing change?


Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
hack/util.sh Outdated Show resolved Hide resolved
@village-way village-way force-pushed the main branch 3 times, most recently from 9358e23 to c1737b3 Compare April 29, 2024 01:54
@duanmengkk
Copy link
Contributor

/lgtm
/approve

@kosmos-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: duanmengkk, village-way

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kosmos-robot kosmos-robot merged commit 1563d25 into kosmos-io:main Apr 29, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants