update readme and support kind to deploy kosmos #373
Conversation
1. update readme and fix kosmosctl version can not overwrite by make VERSION env param 2. add dev workflow images for local debug and test 3. update readme, delete Deprecated serviceAccount config, update make clean 4. Add config for ci.yml to enable manual triggering 5. macos make improve, add go clean cache(clean.sh), add verify-all.sh for make verify Signed-off-by: wangdepeng <[email protected]>
…DME.md Signed-off-by: wangdepeng <[email protected]>
kosmos-robot
requested review from
duanmengkk,
wangyizhi1 and
wuyingjun-lucky
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: village-way The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -0,0 +1,76 @@ | |||
| # ClusterTree(集群容器编排) | |||
There was a problem hiding this comment.
Is it okay to put this doc here? what do you think @duanmengkk
There was a problem hiding this comment.
We need to redesign the entire document.
| REGISTRY: ghcr.io/${{ github.repository_owner }}/${{ github.repository_name }} | ||
| TAG: ${{ steps.previoustag.outputs.tag }} | ||
| run: | | ||
| make upload-images REGISTRY=${REGISTRY%?} VERSION=$TAG |
There was a problem hiding this comment.
to push dev image to person ghcr
| clusterlink-network-manager \ | ||
| clusterlink-proxy \ | ||
| clustertree-cluster-manager \ | ||
| scheduler \ |
There was a problem hiding this comment.
We can use make mp-image-clusterlink-controller-manager to make arm images
| kubectl get nodes | ||
| ``` | ||
| - use this command we can see the two cluster nodes Name like `kosmos-*` roles as `agent` | ||
| <div><img src="docs/images/demo-check-node.png" style="width:400px;" alt="nodes"/></div> | ||
|
|
There was a problem hiding this comment.
Seens good，But we need to redesign the entire document.
| @@ -0,0 +1,76 @@ | |||
| # ClusterTree(集群容器编排) | |||
There was a problem hiding this comment.
We need to redesign the entire document.
|
This is a nice code submission, but this PR contains too many features. We need to break it down, so I will close it for now. /cc @village-way |
|
@duanmengkk: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What does this PR do?
Which issue(s) does this PR fix?
Fixes #365
Special notes for your reviewer:
can not make on macos
@duanmengkk
@assign duanmengkk
Does this PR introduce a user-facing change?