Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finalizer for mcs #334

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

duanmengkk
Copy link
Contributor

What type of PR is this?

What does this PR do?

Which issue(s) does this PR fix?

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@kosmos-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: duanmengkk
To complete the pull request process, please assign wuyingjun-lucky after the PR has been reviewed.
You can assign the PR to them by writing /assign @wuyingjun-lucky in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@duanmengkk duanmengkk force-pushed the add_finalizer_for_mcs branch 3 times, most recently from 73369ba to cf93022 Compare December 22, 2023 08:25
@duanmengkk duanmengkk marked this pull request as draft December 23, 2023 07:41
@duanmengkk duanmengkk force-pushed the add_finalizer_for_mcs branch 5 times, most recently from 9ba96b2 to cd41320 Compare December 24, 2023 08:16
@duanmengkk duanmengkk marked this pull request as ready for review December 24, 2023 08:19
@duanmengkk duanmengkk force-pushed the add_finalizer_for_mcs branch 3 times, most recently from aeb720b to 5888413 Compare December 25, 2023 01:08
@duanmengkk
Copy link
Contributor Author

/retest

@duanmengkk duanmengkk force-pushed the add_finalizer_for_mcs branch 4 times, most recently from 542be25 to 939fa2a Compare December 26, 2023 01:39
@duanmengkk duanmengkk force-pushed the add_finalizer_for_mcs branch from 939fa2a to 28d8ccd Compare December 26, 2023 03:29
@wangyizhi1
Copy link
Member

/lgtm

@wangyizhi1
Copy link
Member

/approve

@wuyingjun-lucky wuyingjun-lucky merged commit 47e012b into kosmos-io:main Dec 26, 2023
6 checks passed
@duanmengkk duanmengkk deleted the add_finalizer_for_mcs branch December 28, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants