Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make kosmosctl support --context and support e2e test for kosmosctl #325

Merged
merged 1 commit into from
Dec 25, 2023
Merged

feat: make kosmosctl support --context and support e2e test for kosmosctl #325

merged 1 commit into from
Dec 25, 2023

Conversation

duanmengkk
Copy link
Contributor

@duanmengkk duanmengkk commented Dec 14, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What does this PR do?

Which issue(s) does this PR fix?

Fixes #326

Special notes for your reviewer:

Does this PR introduce a user-facing change?

@kosmos-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: duanmengkk
To complete the pull request process, please assign xyz2277 after the PR has been reviewed.
You can assign the PR to them by writing /assign @xyz2277 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@duanmengkk duanmengkk marked this pull request as draft December 14, 2023 05:50
@duanmengkk duanmengkk changed the title feat: make kosmosctl support --context feat: make kosmosctl support --context and support e2e test for kosmosctl Dec 14, 2023
@duanmengkk duanmengkk force-pushed the kosmosctl_support_context branch 5 times, most recently from 7ce79f9 to 36dbb37 Compare December 19, 2023 11:48
@duanmengkk duanmengkk marked this pull request as ready for review December 20, 2023 01:14
@duanmengkk
Copy link
Contributor Author

/cc @ONE7live @wuyingjun-lucky

ONE7live
ONE7live reviewed Dec 20, 2023
View reviewed changes
pkg/kosmosctl/join/join.go Outdated Show resolved Hide resolved
pkg/kosmosctl/uninstall/uninstall.go Outdated Show resolved Hide resolved
pkg/kosmosctl/unjoin/unjoin.go Outdated Show resolved Hide resolved
pkg/kosmosctl/unjoin/unjoin.go Outdated Show resolved Hide resolved
pkg/kosmosctl/install/install.go Show resolved Hide resolved
@duanmengkk duanmengkk force-pushed the kosmosctl_support_context branch from db46893 to 40620fc Compare December 20, 2023 09:40
@wuyingjun-lucky wuyingjun-lucky merged commit 5a6b267 into kosmos-io:main Dec 25, 2023
6 of 7 checks passed
@duanmengkk duanmengkk deleted the kosmosctl_support_context branch February 8, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ONE7live ONE7live ONE7live left review comments

@wuyingjun-lucky wuyingjun-lucky Awaiting requested review from wuyingjun-lucky

@xyz2277 xyz2277 Awaiting requested review from xyz2277

Assignees
No one assigned
Labels
kind/feature size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support --context for kosmosctl
4 participants
@duanmengkk @kosmos-robot @ONE7live @wuyingjun-lucky