Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add e2e approvers and uncomment some testcase #316

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

duanmengkk
Copy link
Contributor

What type of PR is this?

/kind cleanup

What does this PR do?

Which issue(s) does this PR fix?

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@duanmengkk
Copy link
Contributor Author

/lgtm

@kosmos-robot
Copy link
Contributor

@duanmengkk: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@duanmengkk
Copy link
Contributor Author

/cc @wuyingjun-lucky the network bug is fixed. so the e2e test case can be uncomment

@duanmengkk duanmengkk marked this pull request as ready for review December 8, 2023 01:23
@duanmengkk
Copy link
Contributor Author

/cc @wuyingjun-lucky It is ok to merge

@kosmos-robot
Copy link
Contributor

@duanmengkk: GitHub didn't allow me to request PR reviews from the following users: It, is, ok, to, merge.

Note that only kosmos-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @wuyingjun-lucky It is ok to merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuyingjun-lucky
Copy link
Member

/approve

@kosmos-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: duanmengkk, wuyingjun-lucky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wuyingjun-lucky
Copy link
Member

/lgtm

@kosmos-robot kosmos-robot merged commit 244dd33 into kosmos-io:main Dec 11, 2023
6 of 7 checks passed
@duanmengkk duanmengkk deleted the add_e2e_owners branch December 11, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants