-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add e2e approvers and uncomment some testcase #316
Conversation
c4c0414
to
75f06bd
Compare
75f06bd
to
933bfb4
Compare
933bfb4
to
b52c2a9
Compare
Signed-off-by: duanmengkk <[email protected]>
b52c2a9
to
8342f62
Compare
/lgtm |
@duanmengkk: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @wuyingjun-lucky the network bug is fixed. so the e2e test case can be uncomment |
/cc @wuyingjun-lucky It is ok to merge |
@duanmengkk: GitHub didn't allow me to request PR reviews from the following users: It, is, ok, to, merge. Note that only kosmos-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: duanmengkk, wuyingjun-lucky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind cleanup
What does this PR do?
Which issue(s) does this PR fix?
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?