feat: add a way to exclude nodes #290
Conversation
Signed-off-by: wangyizhi1 <[email protected]>
| @@ -43,15 +43,15 @@ type Reconciler struct { | |||
| var predicatesFunc = predicate.Funcs{ | |||
| CreateFunc: func(createEvent event.CreateEvent) bool { | |||
| node := createEvent.Object.(*corev1.Node) | |||
| return !utils.IsKosmosNode(node) | |||
| return !utils.IsKosmosNode(node) && !utils.IsExcludeNode(node) | |||
There was a problem hiding this comment.
This solves the problem of the before kosmos install, but in subsequent runs, if a node is changed from a normal node to a exclude node, this can lead to problems or potential bugs. For example, updates related to the node associated with the clustenode will not be synchronized.
There was a problem hiding this comment.
I think we could live a TODO here, and add detail description or issue. then we can merge this PR
There was a problem hiding this comment.
Yes, currently, this label needs to be added before the controller-manager runs. I have created an issue for it and will further optimize it. #294
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hanweisen, wangyizhi1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What does this PR do?
feat: add a way to exclude nodes
Which issue(s) does this PR fix?
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?