Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support one-to-many model for the leaf node feature #287

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

qiuming520
Copy link
Member

What type of PR is this?

support one-to-many model for the leaf node feature

/kind feature

What does this PR do?

Which issue(s) does this PR fix?

Fixes ##285

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@wuyingjun-lucky
Copy link
Member

/cc @OrangeBao

@wuyingjun-lucky wuyingjun-lucky marked this pull request as ready for review November 23, 2023 11:36
@wuyingjun-lucky
Copy link
Member

/kind feature

1 similar comment
@wuyingjun-lucky
Copy link
Member

/kind feature

@wuyingjun-lucky wuyingjun-lucky marked this pull request as draft November 23, 2023 11:56
@wuyingjun-lucky
Copy link
Member

/cc @yuleichun-striving

@kosmos-io kosmos-io deleted a comment from kosmos-robot Nov 23, 2023
@kosmos-io kosmos-io deleted a comment from kosmos-robot Nov 23, 2023
@kosmos-io kosmos-io deleted a comment from kosmos-robot Nov 23, 2023
@kosmos-io kosmos-io deleted a comment from kosmos-robot Nov 23, 2023
@wuyingjun-lucky wuyingjun-lucky marked this pull request as ready for review November 23, 2023 12:40
@wuyingjun-lucky wuyingjun-lucky marked this pull request as draft November 23, 2023 12:41
@wuyingjun-lucky wuyingjun-lucky marked this pull request as ready for review November 23, 2023 12:48
@wuyingjun-lucky wuyingjun-lucky marked this pull request as draft November 23, 2023 12:48
@wuyingjun-lucky wuyingjun-lucky marked this pull request as ready for review November 23, 2023 12:59
@wuyingjun-lucky wuyingjun-lucky marked this pull request as draft November 23, 2023 12:59
@qiuming520
Copy link
Member Author

@qiuming520 Are you ready ?
yes~now do some tests

@qiuming520 qiuming520 force-pushed the main branch 2 times, most recently from a76c36c to 9e483bd Compare December 7, 2023 13:05
@qiuming520 qiuming520 force-pushed the main branch 3 times, most recently from 63a0d57 to 9761b1f Compare December 8, 2023 01:05
.golangci.yml Outdated Show resolved Hide resolved
test/e2e/leaf_node_test.go Show resolved Hide resolved
@qiuming520 qiuming520 force-pushed the main branch 2 times, most recently from bf78292 to cccfccf Compare December 8, 2023 09:47
@yuleichun-striving
Copy link
Contributor

/lgtm

@duanmengkk
Copy link
Contributor

the e2e test case is updated,fetch the new code and push again @qiuming520

@kosmos-robot kosmos-robot removed the lgtm label Dec 11, 2023
@wuyingjun-lucky
Copy link
Member

/assign @duanmengkk

@duanmengkk
Copy link
Contributor

/lgtm

@duanmengkk
Copy link
Contributor

/approve

@duanmengkk
Copy link
Contributor

/assign @wuyingjun-lucky

@wuyingjun-lucky
Copy link
Member

/approve

@kosmos-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: duanmengkk, qiuming520, wuyingjun-lucky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kosmos-robot kosmos-robot merged commit b7a02b7 into kosmos-io:main Dec 11, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants