feat: kosmosctl image pull/push #279
Conversation
|
/assign @wuyingjun-lucky @duanmengkk |
pkg/kosmosctl/image/pull.go
Outdated
|
|
||
| func (o *CommandPullOptions) Run() error { | ||
| // 1. pull image from public registry | ||
| klog.Info("Start pulling images ...") |
There was a problem hiding this comment.
I think we may set the log level
There was a problem hiding this comment.
Okay, I'll set the output level of the log on the entire code
pkg/kosmosctl/image/pull.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (o *CommandPullOptions) ImagePull() (imageList []string, err error) { |
There was a problem hiding this comment.
ImagePull ---> pullImage
pkg/utils/constants.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| ClusterTreeKnodeManager = "ghcr.io/kosmos-io/clustertree-knode-manager" |
There was a problem hiding this comment.
I think the KnodeManager is discard
There was a problem hiding this comment.
Okay, I'll recheck the names of all the images.
feat: kosmosctl image pull/push Signed-off-by: kuangcheng <[email protected]> fix: add klog level and check image name Signed-off-by: kuangcheng <[email protected]>
kuangcheng66
force-pushed
the
kosmosctl-install-image-version
branch
from
6a22894 to
546d553
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kuangcheng66, wuyingjun-lucky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
feat: kosmosctl image pull/push
What type of PR is this?
What does this PR do?
kosmosctl image pull --kosmos-version=[default: latest] --coredns-version=[default: latest] --eps-version=[default: latest]kosmoscrl image push --artifact=[*.tar.gz] --username=[registry-username] --private-registry=[private-registry-name]Which issue(s) does this PR fix?
Fixes #109