Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not use podIP as the address of the node #274

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

OrangeBao
Copy link
Contributor

@OrangeBao OrangeBao commented Nov 22, 2023

What type of PR is this?

/kind feature

What does this PR do?

Which issue(s) does this PR fix?

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Verified

This commit was signed with the committer’s verified signature.
gao12312 GaoYuan
Signed-off-by: OrangeBao <baoyinghai_yewu@cmss.chinamobile.com>
// spec := corev1.NodeSpec{
// Taints: rootNode.Spec.Taints,
// }
clone.Spec.Taints = rootNode.Spec.Taints
clone.Status = node.Status
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanweisen
Copy link
Contributor

/lgtm

@hanweisen
Copy link
Contributor

/approve

@kosmos-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hanweisen, OrangeBao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kosmos-robot kosmos-robot merged commit b863b39 into kosmos-io:main Nov 22, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants