fix:1.root pvc could be lost possibly; 2.leaf pvc spec could not be m… #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odified 3. root pv nodeSelectorTerms Signed-off-by: zhangyongxi <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xyz2277 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
duanmengkk
reviewed
Nov 15, 2023
| @@ -291,15 +291,15 @@ func (c *ClusterController) setupControllers(mgr manager.Manager, cluster *kosmo | |||
| return fmt.Errorf("error starting podUpstreamReconciler %s: %v", podcontrollers.LeafPodControllerName, err) | |||
| } | |||
|
|
|||
| err := c.setupStorageControllers(mgr, nodes, leafClientset, cluster.Name) | |||
| err := c.setupStorageControllers(mgr, utils.IsOne2OneMode(cluster), cluster.Name) | |||
| if err != nil { | |||
There was a problem hiding this comment.
we can use leafModelHandler( AggregationModelHandler DispersionModelHandler) other than if .... else ...
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…odified 3. root pv nodeSelectorTerms
What type of PR is this?
/kind bug
What does this PR do?
fix:1.root pvc could be lost possibly;
2.leaf pvc spec could not be modified
3. root pv nodeSelectorTerms is wrong
Which issue(s) does this PR fix?
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?