Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add address for knode #224

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

OrangeBao
Copy link
Contributor

What type of PR is this?

/kind feature

What does this PR do?

Which issue(s) does this PR fix?

Fixes #223

Special notes for your reviewer:

Does this PR introduce a user-facing change?

add address for knode

@OrangeBao
Copy link
Contributor Author

/cc @hanweisen

@xyz2277
Copy link
Collaborator

xyz2277 commented Nov 12, 2023

/lgtm

@xyz2277
Copy link
Collaborator

xyz2277 commented Nov 12, 2023

/approve

@kosmos-robot kosmos-robot added lgtm and removed lgtm labels Nov 12, 2023
@kosmos-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OrangeBao, xyz2277

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: OrangeBao <[email protected]>
@xyz2277
Copy link
Collaborator

xyz2277 commented Nov 12, 2023

/lgtm

@kosmos-robot kosmos-robot merged commit 88a3efe into kosmos-io:main Nov 12, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WIP: add address for knode
3 participants