feat: add offline-installation-tool.sh #122
Conversation
|
/cc @duanmengkk @ONE7live |
|
@kuangcheng66: GitHub didn't allow me to request PR reviews from the following users: duanmengkk, ONE7live. Note that only kosmos-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -0,0 +1,123 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| # Copyright 2018 The KubeSphere Authors. | |||
There was a problem hiding this comment.
Certificate information needs attention
There was a problem hiding this comment.
ok, I will fix it
| for image in $(<${ImagesList}); do | ||
| if [[ ${image} =~ ^\#\#.* ]]; then | ||
| if [[ -n ${images} ]]; then | ||
| echo "" |
There was a problem hiding this comment.
change echo "" —> echo -e "a\b..." maybe better, what do you think?
kuangcheng66
force-pushed
the
offline-install
branch
from
de92fd4 to
6bc6a03
Compare
| docker tag $image $imageUrl | ||
| docker push $imageUrl | ||
| done | ||
| fi |
|
This shell script doesn't seem to be an 'offline installation tool,' but rather appears to be an image handling script？ |
kuangcheng66
changed the title
yes，it seems that we still need to discuss it carefully |
wangyizhi1
force-pushed
the
main
branch
3 times, most recently
from
f474e34 to
6488475
Compare
|
/hold |
kuangcheng66
force-pushed
the
offline-install
branch
from
6bc6a03 to
aedba1f
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kuangcheng66 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kuangcheng66 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What does this PR do?
Which issue(s) does this PR fix?
Fixes #109
Special notes for your reviewer:
Additional Comments: