Related data belonging to another parent should not be updated

[bianchi]

When the primary key of the related data did not belong to parent, change was still being made.

Eg:

$user1->tasks()->sync([
            // Update
            [
                'id' => 3, // id from a task which belongs to another user
                'content' => 'Trying to change a task which is not mine',
            ],
 ]);

I see two approaches:

1. Ignore this record. In the example user1 would end with no tasks
2. Creates a new record. In the example user1 would end with a new task with another id
3. Throws an error

I implemented option 2 here.

[korridor]

@bianchi Thanks for the PR, and thank you for your patience! For me, this was not a problem since we validate the array that we put in the sync() function, but I agree that this is unexpected behavior and can lead to issues.

I will look into this in more detail the next week!

[korridor]

@bianchi Sorry I forgot about the issue. I resolved the issue you reported here in the PR #10.

I implemented the approach 3 and there is now a new function attribute called $throwOnIdNotInScope that can be set to false to get the behavior of approach 1.

The reason I did not use your implementation of approach 2 is that I could not think of a scenario in which this would be my preferred behavior. If you provide me with a real-world scenario in which approach 2 is needed, I might reconsider.

Since you reported this bug, I'll, of course, add you to the credits of the release!