Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rstdoc broken in 4.0.0-beta.2 #615

Closed
amir-zeldes opened this issue Aug 9, 2019 · 1 comment · Fixed by #618
Closed

rstdoc broken in 4.0.0-beta.2 #615

amir-zeldes opened this issue Aug 9, 2019 · 1 comment · Fixed by #618
Assignees
@thomaskrause

Comments

@amir-zeldes
Copy link
Collaborator

@thomaskrause , I'm testing ANNIS 4.0.0-beta.2 on GUM now and two problems appear in rstdoc in the front-end:

  1. Leaf node display an ID like structure883 instead of their EDU number (1, 2, 3 etc.)
  2. Tokens are randomly scrambled within leaf node text

See both errors in this screenshot:

image
thomaskrause added a commit that referenced this issue Aug 15, 2019
@thomaskrause
Iterate over tokens of a single sentence in in order of the tokens in…
17ed5fc 
… the text.

This should fix parts of issue #615
thomaskrause added a commit that referenced this issue Aug 16, 2019
@thomaskrause
Only output the single ID if start and end are actually the same, thi…
72e9cbf 
…s fixes some issues that where introduced after fixing the display for #615
@thomaskrause thomaskrause self-assigned this Aug 16, 2019
@thomaskrause
Copy link
Member

The issue with using the node name as ID instead of the sentence index was a "intended behavior" introduced with the latest changes on the RST visualizer to support signals. I updated it to use the sentence ID again, but only display a single number if left and right are the same.

@thomaskrause thomaskrause mentioned this issue Aug 16, 2019
Merged
thomaskrause added a commit that referenced this issue Aug 16, 2019
@thomaskrause
Iterate over tokens of a single sentence in in order of the tokens in…
d6c2fb3 
… the text.

This should fix parts of issue #615
thomaskrause added a commit that referenced this issue Aug 16, 2019
@thomaskrause
Only output the single ID if start and end are actually the same, thi…
70dcf6a 
…s fixes some issues that where introduced after fixing the display for #615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomaskrause thomaskrause

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues with the RST visualizer and token ordering korpling/ANNIS
2 participants
@thomaskrause @amir-zeldes