Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnnisUser does not implement Serializable #434

Closed
thomaskrause opened this issue Sep 3, 2015 · 0 comments
Closed

AnnisUser does not implement Serializable #434

thomaskrause opened this issue Sep 3, 2015 · 0 comments
Assignees
Labels
Milestone

Comments

@thomaskrause
Copy link
Member

The class AnnisUser is stored in the session which could be persisted, but is not serializable. This will lead to errors when a persistent disk cache is used in the web server.

@thomaskrause thomaskrause self-assigned this Sep 3, 2015
@thomaskrause thomaskrause added this to the 3.3.6 milestone Sep 3, 2015
thomaskrause added a commit that referenced this issue Sep 3, 2015
AnnisUser was not serializable. In case the session was written to the disk by the server AnnisUser could either have transient variables (like the Client) which are invalid after the object has been restored or you can re-create the client on request but then you need to store the password in the session disk storage as well. While creating the "Client" object on the fly and caching it is now implemented, the "password" field is still marked as "transient" to ensure it is not written to disk.

The actual new behavior is that the user is properly informed whenever the password was lost because it was written to disk and he/she is requested to login again instead of silently failing in this case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant