Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating a SecAccessControl with a protection #193

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

alex
Copy link
Contributor

@alex alex commented Mar 22, 2024

No description provided.

@alex alex force-pushed the access-control-protection branch 2 times, most recently from 8d5b8c1 to 2eb7f1c Compare March 23, 2024 16:09
@kornelski
Copy link
Owner

Could it use a more specific type than CFTypeRef?

@alex
Copy link
Contributor Author

alex commented Mar 27, 2024

I'm not sure :-) CFTypeRef is what the underlying C API uses. Do you have a thought as to how we might model it differently here?

@kornelski
Copy link
Owner

I'm not familiar with that API. In general in the higher level wrapper I'd prefer to hide ObjC-isms and have type safety where possible.

What kind of objects are you passing there? Where do you get them from?

@alex
Copy link
Contributor Author

alex commented Mar 28, 2024

For my use case, I'm passing a CFString: kSecAttrAccessibleWhenUnlockedThisDeviceOnly

@alex alex force-pushed the access-control-protection branch from 2eb7f1c to 5aee280 Compare March 28, 2024 01:32
@alex
Copy link
Contributor Author

alex commented Mar 28, 2024

Ok, now uses an enum.

@kornelski kornelski merged commit ebcc98e into kornelski:main Mar 28, 2024
4 of 6 checks passed
@kornelski
Copy link
Owner

Thanks

@alex alex deleted the access-control-protection branch March 28, 2024 02:37
@alex
Copy link
Contributor Author

alex commented Mar 28, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants