clippy
111 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 111 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.81.0 (eeb90cda1 2024-09-04)
- cargo 1.81.0 (2dbb1af80 2024-08-20)
- clippy 0.1.81 (eeb90cda 2024-09-04)
Annotations
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\lib.rs:394:17
|
394 | / tokio::select! {
395 | | _ = connection::connection_lifecycle_loop() => (),
396 | | _ = SHUTDOWN_NOTIFIER.notified() => (),
397 | | }
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\lib.rs:241:13
|
241 | / tokio::select! {
242 | | _ = web_server => (),
243 | | _ = SHUTDOWN_NOTIFIER.notified() => (),
244 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 54 in alvr\server\src\lib.rs
github-actions / clippy
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> alvr\server\src\lib.rs:54:30
|
54 | static ref VIDEO_SENDER: Mutex<Option<mpsc::UnboundedSender<(VideoFrameHeaderPacket, Vec<u8>)>>> =
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\connection.rs:1071:5
|
1071 | / tokio::select! {
1072 | | // Spawn new tasks and let the runtime manage threading
1073 | | res = spawn_cancelable(receive_loop) => {
1074 | | alvr_session::log_event(ServerEvent::ClientDisconnected);
... |
1101 | | }
1102 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 1019 in alvr\server\src\connection.rs
github-actions / clippy
length comparison to zero
warning: length comparison to zero
--> alvr\server\src\connection.rs:1019:59
|
1019 | if src_ham.vertices.len() == 0 || src_ham.indices.len() == 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `src_ham.indices.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
Check warning on line 1019 in alvr\server\src\connection.rs
github-actions / clippy
length comparison to zero
warning: length comparison to zero
--> alvr\server\src\connection.rs:1019:28
|
1019 | if src_ham.vertices.len() == 0 || src_ham.indices.len() == 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `src_ham.vertices.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\connection.rs:594:25
|
594 | let stream_socket = tokio::select! {
| _________________________^
595 | | res = StreamSocketBuilder::connect_to_client(
596 | | client_ip,
597 | | settings.connection.stream_port,
... |
605 | | }
606 | | };
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
warning: current MSRV (Minimum Supported Rust Version) is `1.58.0` but this item is stable since `1.64.0`
--> alvr\server\src\connection.rs:542:9
|
542 | / tokio::select! {
543 | | res = try_connection_future => {
544 | | match res {
545 | | Either::Left(Ok(client_ip)) => {
... |
562 | | _ = CLIENTS_UPDATED_NOTIFIER.notified() => return Ok(()),
563 | | };
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: `#[warn(clippy::incompatible_msrv)]` on by default
= note: this warning originates in the macro `$crate::select` which comes from the expansion of the macro `tokio::select` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 88 in alvr\server\src\connection.rs
github-actions / clippy
field `version` is never read
warning: field `version` is never read
--> alvr\server\src\connection.rs:88:5
|
86 | struct ConnectionInfo {
| -------------- field in this struct
87 | client_ip: IpAddr,
88 | version: Option<Version>,
| ^^^^^^^
Check warning on line 53 in alvr\server\src\connection.rs
github-actions / clippy
field `hostname` is never read
warning: field `hostname` is never read
--> alvr\server\src\connection.rs:53:5
|
52 | struct ClientId {
| -------- field in this struct
53 | hostname: String,
| ^^^^^^^^
|
= note: `ClientId` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
Check warning on line 19 in alvr\server\src\lib.rs
github-actions / clippy
unused import: `prelude::*`
warning: unused import: `prelude::*`
--> alvr\server\src\lib.rs:19:37
|
19 | use alvr_common::{lazy_static, log, prelude::*, ALVR_VERSION};
| ^^^^^^^^^^
Check warning on line 8 in alvr\server\src\connection.rs
github-actions / clippy
unused imports: `Mat4` and `log`
warning: unused imports: `Mat4` and `log`
--> alvr\server\src\connection.rs:8:12
|
8 | glam::{Mat4, Quat, Vec2, Vec3},
| ^^^^
9 | log,
| ^^^
|
= note: `#[warn(unused_imports)]` on by default
Check warning on line 62 in alvr\launcher\src\commands.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\launcher\src\commands.rs:62:15
|
62 | .args(&["/PID", &pid.to_string(), "/F"])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/PID", &pid.to_string(), "/F"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 52 in alvr\launcher\src\commands.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\launcher\src\commands.rs:52:50
|
52 | spawn_no_window(Command::new("cmd").args(&["/C", "start", "steam://rungameid/250820"]));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "start", "steam://rungameid/250820"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
Check warning on line 1168 in alvr\xtask\src/main.rs
github-actions / clippy
useless use of `vec!`
warning: useless use of `vec!`
--> alvr\xtask\src/main.rs:1165:36
|
1165 | let flavours = vec![
| ____________________________________^
1166 | | (for_generic, AndroidFlavor::Generic, abi_target.clone()),
1167 | | (for_pico, AndroidFlavor::Pico, Option::None),
1168 | | ];
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `#[warn(clippy::useless_vec)]` on by default
help: you can use an array directly
|
1165 ~ let flavours = [(for_generic, AndroidFlavor::Generic, abi_target.clone()),
1166 ~ (for_pico, AndroidFlavor::Pico, Option::None)];
|
Check warning on line 1098 in alvr\xtask\src/main.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> alvr\xtask\src/main.rs:1098:27
|
1098 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
= note: `#[warn(clippy::needless_update)]` on by default
Check warning on line 977 in alvr\xtask\src/main.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src/main.rs:977:41
|
977 | .filter(|entry| is_package_file(&entry))
| ^^^^^^ help: change this to: `entry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 969 in alvr\xtask\src/main.rs
github-actions / clippy
unneeded `return` statement
warning: unneeded `return` statement
--> alvr\xtask\src/main.rs:969:13
|
969 | return ["apk", "aar", "idsig"].contains(&ext_str);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
969 - return ["apk", "aar", "idsig"].contains(&ext_str);
969 + ["apk", "aar", "idsig"].contains(&ext_str)
|
Check warning on line 850 in alvr\xtask\src/main.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src/main.rs:850:61
|
850 | let run_ait_cmd = |cmd: &str| command::run_in(&ait_dir, &cmd).unwrap();
| ^^^^ help: change this to: `cmd`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 823 in alvr\xtask\src/main.rs
github-actions / clippy
manual implementation of an assign operation
warning: manual implementation of an assign operation
--> alvr\xtask\src/main.rs:823:9
|
823 | archs = archs + "_debug";
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `archs += "_debug"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: `#[warn(clippy::assign_op_pattern)]` on by default
Check warning on line 817 in alvr\xtask\src/main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\xtask\src/main.rs:817:36
|
817 | alxr_client_build_dir.join(&cert),
| ^^^^^ help: change this to: `cert`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 816 in alvr\xtask\src/main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\xtask\src/main.rs:816:30
|
816 | alxr_client_dir.join(&cert),
| ^^^^^ help: change this to: `cert`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 786 in alvr\xtask\src/main.rs
github-actions / clippy
redundant closure
warning: redundant closure
--> alvr\xtask\src/main.rs:786:57
|
786 | for arch in [UWPArch::X86_64, UWPArch::Aarch64].map(|x| batch_arch_str(x)) {
| ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `batch_arch_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
Check warning on line 783 in alvr\xtask\src/main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\xtask\src/main.rs:783:52
|
783 | let pack_map_path = alxr_client_build_dir.join(&pack_map_fname);
| ^^^^^^^^^^^^^^^ help: change this to: `pack_map_fname`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 779 in alvr\xtask\src/main.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src/main.rs:779:24
|
779 | .unwrap_or(&alxr_client_build_dir),
| ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `alxr_client_build_dir`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow