tidy up oxr extension list #555
clippy
106 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 106 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.78.0 (9b00956e5 2024-04-29)
- cargo 1.78.0 (54d8815d0 2024-03-26)
- clippy 0.1.78 (9b00956e 2024-04-29)
Annotations
Check warning on line 54 in alvr\server\src\lib.rs
github-actions / clippy
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> alvr\server\src\lib.rs:54:30
|
54 | static ref VIDEO_SENDER: Mutex<Option<mpsc::UnboundedSender<(VideoFrameHeaderPacket, Vec<u8>)>>> =
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
Check warning on line 88 in alvr\server\src\connection.rs
github-actions / clippy
field `version` is never read
warning: field `version` is never read
--> alvr\server\src\connection.rs:88:5
|
86 | struct ConnectionInfo {
| -------------- field in this struct
87 | client_ip: IpAddr,
88 | version: Option<Version>,
| ^^^^^^^
Check warning on line 53 in alvr\server\src\connection.rs
github-actions / clippy
field `hostname` is never read
warning: field `hostname` is never read
--> alvr\server\src\connection.rs:53:5
|
52 | struct ClientId {
| -------- field in this struct
53 | hostname: String,
| ^^^^^^^^
|
= note: `ClientId` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
Check warning on line 19 in alvr\server\src\lib.rs
github-actions / clippy
unused import: `prelude::*`
warning: unused import: `prelude::*`
--> alvr\server\src\lib.rs:19:37
|
19 | use alvr_common::{lazy_static, log, prelude::*, ALVR_VERSION};
| ^^^^^^^^^^
Check warning on line 8 in alvr\server\src\connection.rs
github-actions / clippy
unused imports: `Mat4`, `log`
warning: unused imports: `Mat4`, `log`
--> alvr\server\src\connection.rs:8:12
|
8 | glam::{Mat4, Quat, Vec2, Vec3},
| ^^^^
9 | log,
| ^^^
|
= note: `#[warn(unused_imports)]` on by default
Check warning on line 638 in alvr\audio\src\lib.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> alvr\audio\src\lib.rs:638:17
|
638 | &mut *self.sample_buffer.lock(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut self.sample_buffer.lock()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
Check warning on line 220 in alvr\sockets\src\stream_socket\mod.rs
github-actions / clippy
field `stream_id` is never read
warning: field `stream_id` is never read
--> alvr\sockets\src\stream_socket\mod.rs:220:5
|
219 | pub struct StreamReceiver<T> {
| -------------- field in this struct
220 | stream_id: StreamId,
| ^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 617 in alvr\session\src\lib.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\session\src\lib.rs:617:53
|
617 | let session_desc = match fs::read_to_string(&session_path) {
| ^^^^^^^^^^^^^ help: change this to: `session_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
Check warning on line 1156 in alvr\xtask\src\main.rs
github-actions / clippy
useless use of `vec!`
warning: useless use of `vec!`
--> alvr\xtask\src\main.rs:1153:36
|
1153 | let flavours = vec![
| ____________________________________^
1154 | | (for_generic, AndroidFlavor::Generic, abi_target.clone()),
1155 | | (for_pico, AndroidFlavor::Pico, Option::None),
1156 | | ];
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `#[warn(clippy::useless_vec)]` on by default
help: you can use an array directly
|
1153 ~ let flavours = [(for_generic, AndroidFlavor::Generic, abi_target.clone()),
1154 ~ (for_pico, AndroidFlavor::Pico, Option::None)];
|
Check warning on line 1086 in alvr\xtask\src\main.rs
github-actions / clippy
struct update has no effect, all the fields in the struct have already been specified
warning: struct update has no effect, all the fields in the struct have already been specified
--> alvr\xtask\src\main.rs:1086:27
|
1086 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
= note: `#[warn(clippy::needless_update)]` on by default
Check warning on line 965 in alvr\xtask\src\main.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:965:41
|
965 | .filter(|entry| is_package_file(&entry))
| ^^^^^^ help: change this to: `entry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 957 in alvr\xtask\src\main.rs
github-actions / clippy
unneeded `return` statement
warning: unneeded `return` statement
--> alvr\xtask\src\main.rs:957:13
|
957 | return ["apk", "aar", "idsig"].contains(&ext_str);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
957 - return ["apk", "aar", "idsig"].contains(&ext_str);
957 + ["apk", "aar", "idsig"].contains(&ext_str)
|
Check warning on line 838 in alvr\xtask\src\main.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:838:61
|
838 | let run_ait_cmd = |cmd: &str| command::run_in(&ait_dir, &cmd).unwrap();
| ^^^^ help: change this to: `cmd`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 811 in alvr\xtask\src\main.rs
github-actions / clippy
manual implementation of an assign operation
warning: manual implementation of an assign operation
--> alvr\xtask\src\main.rs:811:9
|
811 | archs = archs + "_debug";
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `archs += "_debug"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: `#[warn(clippy::assign_op_pattern)]` on by default
Check warning on line 805 in alvr\xtask\src\main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:805:36
|
805 | alxr_client_build_dir.join(&cert),
| ^^^^^ help: change this to: `cert`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 804 in alvr\xtask\src\main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:804:30
|
804 | alxr_client_dir.join(&cert),
| ^^^^^ help: change this to: `cert`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 774 in alvr\xtask\src\main.rs
github-actions / clippy
redundant closure
warning: redundant closure
--> alvr\xtask\src\main.rs:774:57
|
774 | for arch in [UWPArch::X86_64, UWPArch::Aarch64].map(|x| batch_arch_str(x)) {
| ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `batch_arch_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
Check warning on line 771 in alvr\xtask\src\main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:771:52
|
771 | let pack_map_path = alxr_client_build_dir.join(&pack_map_fname);
| ^^^^^^^^^^^^^^^ help: change this to: `pack_map_fname`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 767 in alvr\xtask\src\main.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:767:24
|
767 | .unwrap_or(&alxr_client_build_dir),
| ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `alxr_client_build_dir`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 748 in alvr\xtask\src\main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:748:32
|
748 | fs::copy(&src_packed_file, &dst_packed_file).unwrap();
| ^^^^^^^^^^^^^^^^ help: change this to: `dst_packed_file`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 721 in alvr\xtask\src\main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:721:69
|
721 | let relative_path = linked_depend_file.strip_prefix(&linked_path).unwrap();
| ^^^^^^^^^^^^ help: change this to: `linked_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 719 in alvr\xtask\src\main.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:719:56
|
719 | .filter(|entry| is_linked_depends_file(&entry))
| ^^^^^^ help: change this to: `entry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 677 in alvr\xtask\src\main.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:677:36
|
677 | if afs::is_dynlib_file(&path) {
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 697 in alvr\xtask\src\main.rs
github-actions / clippy
unneeded `return` statement
warning: unneeded `return` statement
--> alvr\xtask\src\main.rs:697:13
|
697 | return false;
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
697 - return false;
697 + false
|
Check warning on line 606 in alvr\xtask\src\main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:606:40
|
606 | alxr_client_build_dir.join(&pdb_fname),
| ^^^^^^^^^^ help: change this to: `pdb_fname`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args