Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lvtinydom: fix compiler warning [-Wunused-private-field] #597

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Aug 2, 2024

With the int maxLen private field of ldomTextCollector removed, the int maxTextLen arguments to ldomTextCollector(…) and to ldomXRange::getRangeText can also be removed.

Note: calls to getRangeText in cre.cpp will need to be updated.


This change is Reviewable

With the `int maxLen` private field of `ldomTextCollector` removed,
the `int maxTextLen` arguments to `ldomTextCollector(…)` and to
`ldomXRange::getRangeText` can also be removed.
@poire-z
Copy link
Contributor

poire-z commented Aug 2, 2024

Any idea when the maxLen stopped being used (if it ever was used) ? (Maybe you know about a localized git log trick :))
(If it was ever me that removed it, dunno if it was on purpose and a good idea, we could return 36Mb of text :))

@benoit-pierre
Copy link
Contributor Author

It looks like it was added in 3cd5ec4, and never used.

@poire-z poire-z merged commit 07171e7 into koreader:master Aug 2, 2024
1 check passed
@benoit-pierre benoit-pierre deleted the pr/fix_lvtinydom_warning branch August 2, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants