Re-enable: Use the same FT load flags in HB as in FT #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-enable c02f597 (koreader#230) that was reverted by 330d7b1 (koreader#231), as the performance hit has been fixed on Harfbuzz side by using caching. Also re-init HB fonts on hinting mode change to clear HB's internal caches (so we get reproducible renderings when changing hinting mode).
|
Ooh, nice catch on |
|
Note to self: Look into switching to EDIT: And also in Look into |
This was referenced Sep 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable c02f597 (#230) that was reverted by 330d7b1 (#231), as the performance hit has been fixed on Harfbuzz side by using caching.
Also re-init HB fonts on hinting mode change to clear HB's internal caches (so we get reproducible renderings when changing hinting mode - this should fix the frustration I had in koreader/koreader#5359 (comment)).
Recent discussion in koreader/koreader#5359.