Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent crash #29

Merged
merged 1 commit into from
Mar 15, 2016
Merged

prevent crash #29

merged 1 commit into from
Mar 15, 2016

Conversation

frankyifei
Copy link
Contributor

when len==63, it may crash as well

houqp added a commit that referenced this pull request Mar 15, 2016
@houqp houqp merged commit 291d37a into koreader:master Mar 15, 2016
@houqp
Copy link
Member

houqp commented Mar 15, 2016

are you also going to submit this fix to upstream?

@houqp
Copy link
Member

houqp commented Mar 15, 2016

Good catch btw ;) This is the kind of issue that can totally be detected with static analysis.

@frankyifei
Copy link
Contributor Author

It's not common that word length is so long. and I tried scan-build, it gave nothing.

@houqp
Copy link
Member

houqp commented Mar 15, 2016

Interesting... I would expect the out of bound check to be array length agnostic. I also tried coverity before, which caught more bugs compared to llvm's analyzer.

@NiLuJe NiLuJe mentioned this pull request Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants