Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to nx 18 #745

Merged
merged 13 commits into from
Mar 29, 2024
Merged

chore: migrate to nx 18 #745

merged 13 commits into from
Mar 29, 2024

Conversation

timonmasberg
Copy link
Member

@timonmasberg timonmasberg commented Mar 15, 2024 •
edited
Loading

  • migrates to nx 18
  • upgrades commitlint to fix current pre-commit hook issue
  • temporarily run npm install instead of npm ci in api container due to issues with new nx version (added to tech debt list)
  • build apps as prod in CI
  • minor fixes

todos:

@timonmasberg timonmasberg self-assigned this Mar 15, 2024
@timonmasberg
Merge remote-tracking branch 'origin/main' into migrate-to-nx-18
cf61795 
# Conflicts:
#	package-lock.json
#	package.json
@timonmasberg timonmasberg enabled auto-merge (squash) March 15, 2024 15:11
@timonmasberg timonmasberg marked this pull request as draft March 17, 2024 11:12
auto-merge was automatically disabled March 17, 2024 11:12

Pull request was converted to draft

@timonmasberg timonmasberg marked this pull request as ready for review March 19, 2024 15:52
@timonmasberg timonmasberg requested a review from JSPRH March 19, 2024 15:54
JSPRH
JSPRH previously approved these changes Mar 21, 2024
View reviewed changes
@JSPRH JSPRH self-requested a review March 21, 2024 12:40
@JSPRH JSPRH dismissed their stale review March 21, 2024 12:41

There is a problem with the startup commands. Investigating

@JSPRH
Copy link
Contributor

JSPRH commented Mar 21, 2024 •
edited
Loading

npm run serve:spa errors. Seems like they changed the run commands in v18: https://nx.dev/nx-api/next/documents/overview#serving-nextjs-applications
Commands only change if you change targets. Seems like NX v18 now bootstraps with a new naming for targets but this does not affect migrated setups.

@timonmasberg
Merge remote-tracking branch 'origin/main' into migrate-to-nx-18
d4f3216 
# Conflicts:
#	package-lock.json
#	package.json
@JSPRH
Copy link
Contributor

JSPRH commented Mar 21, 2024

There is an issue with unrecognized parameters in the project.json of the SPA project. The issue is already known and a fix is underway.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@timonmasberg timonmasberg enabled auto-merge (squash) March 29, 2024 11:30
@timonmasberg timonmasberg merged commit 445b341 into main Mar 29, 2024
6 checks passed
@timonmasberg timonmasberg deleted the migrate-to-nx-18 branch March 29, 2024 11:33
@timonmasberg
Copy link
Member Author

🎉 This PR is included in version 1.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSPRH JSPRH JSPRH approved these changes

Assignees

@timonmasberg timonmasberg

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timonmasberg @JSPRH